Coliseum Opponents & Rewards Displays Correction #124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From discussion in bug-reports channel on FF6WC Discord:
https://discord.com/channels/666661907628949504/666811452350398493/1216602612762415114
The code in args\coliseum.py must not have been updated back in 1.3.0 when we added in Shuffle+Random% and Random% to the Coliseum options for opponents & rewards. The flags and options code needed to be updated to display the random percentages and to fix clearly erroneous logic checking.
See link above for behavior without the fix.
With the fix:
Ensure that the flag string in the spoiler log is correct (testing flags function).
Ensure that the options in the spoiler log is correct (testing options function for spoiler log).
Ensure that the options in the Track menu is correct (testing options function for Track menu in-game).