feature: filter low value items #58
Conversation
…: -nti --no-trash-items
|
Saw this during a run through, WoB Narshe Wolf room. |
|
|
|
The weird garlic symbol is caused by having a chest containing 0gp, |
constants/items.py
Outdated
| "Dirk", "MithrilKnife", "Guardian", "MithrilBlade", "RegalCutlass", "Crystal", "Ogre Nix", "Mithril Pike", | ||
| "Stout Spear", "Gold Lance", "Partisan", "Imperial", "Kodachi", "Hardened", "Ashura", "Kotetsu", "Forged", | ||
| "Aura", "Strato", "Poison Rod", "Punisher", "Gravity Rod", "MetalKnuckle", "Mithril Claw", "Kaiser", | ||
| "Flail", "Morning Star", "Full Moon", "Boomerang", "Rising Sun", "Cards", "Darts", "Chocobo Brsh", "DaVinci Brsh" |
There was a problem hiding this comment.
Please keep the DaVinci Brsh, Poison Rod, Gravity Rod, Gold Lance, Partisan, and Ogre Nix -- they've all niche use
There was a problem hiding this comment.
Despite my feelings about Ogre Nix, I will make this change
| for chest in possible_chests: | ||
| if not chest.type == Chest.ITEM: | ||
| continue | ||
| item = Item(chest.contents, self.rom) |
There was a problem hiding this comment.
Please change to item = self.items.items[chest.contents] (otherwise there's a merge conflict with other Item changes)
| elif chest.type == Chest.ITEM: | ||
| chest.contents = self.items.get_random() | ||
|
|
||
| if self.args.no_trash_chests: |
There was a problem hiding this comment.
This change only affects -ccsr # (where number is non-zero). I recommend making it apply for all other chest options as well by moving it into its own method called by mod.
asilverthorn
added
Needs Changes
2 participants
feature: Add filtering of low value items from shops and chests. flag…: -nti --no-trash-items
Replacing low value items in chests with their sell GP value
added sell_value and is_trash props to Item
created list of trash items using: https://docs.google.com/spreadsheets/d/1Cit5Xl_TCBPFI4q1NEVQhSYGH1wKY9st_1yee3lzCP8/edit#gid=174771622
Filtered out armors that were bad and had no bonus
Removed ["Charm Bangle", "Coin Toss", "FakeMustache"] just to have a couple relics out of the pool
Trash items are added to excluded items for shops
and low value chests are converted during shuffle_random