Adjust the TypeScript options in Rollup to set rootDir and outDir#52
Open
marllonfrizzo wants to merge 1 commit intofinal-form:masterfrom
Open
Adjust the TypeScript options in Rollup to set rootDir and outDir#52marllonfrizzo wants to merge 1 commit intofinal-form:masterfrom
marllonfrizzo wants to merge 1 commit intofinal-form:masterfrom
Conversation
erikras-richard-agent
approved these changes
Feb 5, 2026
erikras-richard-agent
left a comment
erikras-richard-agent
left a comment
There was a problem hiding this comment.
Good fix! ✅ This solves issue #51 where type definitions were being generated in dist/src/ instead of dist/.
The solution:
Setting rootDir: 'src' tells TypeScript that the source root is in the src directory, so it generates dist/index.d.ts instead of dist/src/index.d.ts, matching the path declared in package.json.
Similar to:
- react-final-form-arrays #186 (fixed duplicate type definitions)
- final-form-focus #42 (added missing type generation)
This is part of the broader TypeScript types publishing fixes across Final Form repos.
Note: CI checks haven't run on this PR (it's from July 2025). @erikras - may need a rebase to trigger CI (Lint, Prettier Check, Unit Tests) before merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
Proposed fix for issue #51
Best regards.