Merged
Conversation
Contributor
mike-finopsorg
commented
Feb 26, 2026
mike-finopsorg
commented
- Fixes how FOCUS Requirements Model is loaded in from the FOCUS GitHub
- Support finding the latest release of a Model file
- Update web output to reflect versions from within the Model details
…n web report Simplify the logic for marking rules as Skipped Clean up error repsonses Add show violation support to the web report Added more violation support to generators Signed-off-by: Mike Fuller <mike@finops.org>
Signed-off-by: Mike Fuller <mike@finops.org>
Signed-off-by: Mike Fuller <mike@finops.org>
Normalise responses to errors with NULL, NaN etc Force error messages to take correct hierachy Introduce more error messages and validation samples Better data loading from CSV Signed-off-by: Mike Fuller <mike@finops.org>
Signed-off-by: Mike Fuller <mike@finops.org>
Signed-off-by: Mike Fuller <mike@finops.org>
Signed-off-by: Mike Fuller <mike@finops.org>
Signed-off-by: Mike Fuller <mike@finops.org>
Signed-off-by: Mike Fuller <mike@finops.org>
Signed-off-by: Mike Fuller <mike@finops.org>
Correctly escape output to prevent any issues with unsafe values in data being processed by web output Fix up filtering issue in rule view. Signed-off-by: Mike Fuller <mike@finops.org>
Signed-off-by: Mike Fuller <mike@finops.org>
…ing with hosting Requirements Model files. Enabling users to find the latest patched version of RM. Bumped version to 2.0.2 for release Signed-off-by: Mike Fuller <mike@finops.org>
Signed-off-by: Mike Fuller <mike@finops.org>
…loads Added warning for malformed versions Added unittests for new version handling Dropped old model file from repo Signed-off-by: Mike Fuller <mike@finops.org>
Signed-off-by: Mike Fuller <mike@finops.org>
Signed-off-by: Mike Fuller <mike@finops.org>
Signed-off-by: Mike Fuller <mike@finops.org>
Matt-Cowsert
approved these changes
Feb 26, 2026
Collaborator
Matt-Cowsert
left a comment
Matt-Cowsert
left a comment
There was a problem hiding this comment.
LGTM. All feedback from PR #134 addressed. Model file bug fixes (ColumnName key fix, CheckValue logic fix) are correct.
Matt-Cowsert
approved these changes
Feb 26, 2026
Collaborator
Matt-Cowsert
left a comment
Matt-Cowsert
left a comment
There was a problem hiding this comment.
LGTM, thanks for promoting these changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.