Modifies updateService related to functions deployment

[brittanycho]

Modifies updateService related to functions deployment

[gemini-code-assist]

Summary of Changes

Hello @brittanycho, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the deployment process for Cloud Run v2 functions by adopting the PATCH HTTP method for service updates, which is more appropriate for modifying existing resources. Additionally, it streamlines the configuration of function triggers by making httpsTrigger the default when no specific trigger type is provided, simplifying deployments for HTTP-based functions.

Highlights

• HTTP Method Update: Updated the updateService function to use the PATCH HTTP method instead of POST for updating Cloud Run v2 services, aligning with REST best practices for partial resource updates.
• Default Trigger Type: Modified the logic for determining the trigger type in endpointFromService to default to httpsTrigger if no TRIGGER_TYPE_ANNOTATION is present or if it explicitly specifies HTTP_TRIGGER.
• Test Case Adjustment: Adjusted a test case in runv2.spec.ts to reflect the new default behavior of using httpsTrigger for services.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• src/gcp/runv2.spec.ts
  • Updated a test service definition to use httpsTrigger instead of eventTrigger.
• src/gcp/runv2.ts
  • Changed the HTTP method from post to patch when calling the client to update a service.
  • Modified the conditional logic for httpsTrigger to apply it by default if TRIGGER_TYPE_ANNOTATION is absent or set to HTTP_TRIGGER.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request makes two main changes related to Cloud Run v2 services for functions deployment. First, it corrects the HTTP method in updateService from POST to PATCH, which is the appropriate verb for updating a resource. Second, it adjusts the logic in endpointFromService to default to an httpsTrigger when a trigger type annotation is not specified, which is a sensible default. The corresponding test has been updated to reflect this new behavior. The changes are correct and improve the logic. I have one minor suggestion for improving code readability.