Cache lint results for unchanged files

[joehan]

Description

Cache lint results for unchanged files. On smaller changes, this saves about a minute per npm run test, which is quite appreciated

[gemini-code-assist]

Summary of Changes

Hello @joehan, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly improves developer workflow efficiency by integrating ESLint caching. By leveraging cached lint results for files that haven't changed, the npm run test command, which includes linting, will execute much faster, saving valuable development time during iterative changes.

Highlights

• Linting Performance Improvement: Enabled ESLint caching to drastically reduce linting times, particularly for incremental changes, by only processing modified files.
• Configuration Updates: Modified package.json scripts to utilize the ESLint --cache flag and updated .gitignore to prevent the cache file from being tracked.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• .gitignore
  • Added .eslintcache to prevent the ESLint cache file from being committed to the repository.
• package.json
  • Modified the lint:quiet and lint:ts scripts to include the --cache flag for ESLint, enabling performance improvements.

Ignored Files

• Ignored by pattern: .github/workflows/** (1)
  • .github/workflows/node-test.yml

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request introduces ESLint caching to improve linting performance, which is a welcome optimization. I have identified a minor redundancy in the package.json scripts where the --cache flag is applied twice when running lint:quiet. Other than that, the changes are correct and follow best practices for ignoring tool-specific cache files.

[gemini-code-assist]

The --cache flag is redundant here because it is already included in the lint:ts script definition on line 25. When npm run lint:quiet is executed, it calls npm run lint:ts, which now includes the cache flag by default.

Suggested change

	"lint:quiet": "npm run lint:ts -- --cache --quiet && npm run lint:other",
	"lint:quiet": "npm run lint:ts -- --quiet && npm run lint:other",