Interpolate physically-mapped elements into VertexOnlyMesh #4213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjward
requested changes
Apr 9, 2025
connorjward
reviewed
Apr 9, 2025
Contributor
connorjward
left a comment
connorjward
left a comment
There was a problem hiding this comment.
Thanks. I'm quite happy with the code. The test looks a little convoluted but that isn't as important as the rest of the source.
pbrubeck
commented
Apr 9, 2025
connorjward
approved these changes
Apr 9, 2025
Contributor
connorjward
left a comment
connorjward
left a comment
There was a problem hiding this comment.
LGTM (but maybe get someone else to verify the maths)
rckirby
requested changes
Apr 9, 2025
Contributor
rckirby
left a comment
rckirby
left a comment
There was a problem hiding this comment.
We should remove the bit about cell sizes for broader discussion, as it's not needed for this PR.
connorjward
requested changes
Apr 9, 2025
connorjward
previously approved these changes
Apr 10, 2025
Contributor
connorjward
left a comment
connorjward
left a comment
There was a problem hiding this comment.
This now looks absolutely fine. If the FIAT one can get merged then this can too.
rckirby
previously approved these changes
Apr 10, 2025
Contributor
rckirby
left a comment
rckirby
left a comment
There was a problem hiding this comment.
I'm happy to do this after we merge FIAT (which still needs a test)
pbrubeck
force-pushed
the
pbrubeck/zany-point-evaluation
branch
from
fb4de34 to
bc82efd
Compare
Co-authored-by: Connor Ward <c.ward20@imperial.ac.uk>
pbrubeck
force-pushed
the
pbrubeck/zany-point-evaluation
branch
from
91444df to
d33efa9
Compare
Contributor
|
Forcing through as only the broken link is holding this up (will fix later today) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR enables interpolation of physically-mapped elements into a
VertexOnlyMesh.Depends on firedrakeproject/fiat#144