Skip to content

Conversation

@JDBetteridge
Copy link
Member

Description


.. _fig-tape:

.. figure:: images/tape.pdf
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean tape.pdf should be removed? Does it exist?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷
Ideally these things should be being generated dynamically, but we need this for the tutorial this week and the .pdf only renders in Safari, but not Chrome and Firefox.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I messed up, that should be an SVG anyway

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also remove the pdf? Just checked and it isn't used anywhere else so it shouldn't be left lying around.

@JDBetteridge JDBetteridge changed the title Add tape.png image Update AIMS schedule Apr 10, 2025
@JDBetteridge JDBetteridge force-pushed the JDBetteridge/fix_adjoint_notes branch from 4d57765 to 53d1f76 Compare April 10, 2025 12:50
@JDBetteridge
Copy link
Member Author

I removed this from demos/eigenvalues_QG_basinmodes/qgbasinmodes.py.rst, because the advice seems to have been removed:

This demo requires SLEPc and slepc4py to be installed. For instructions on how
to install them please follow `these instructions <https://www.firedrakeproject.org/install#slepc>`_.

@JDBetteridge JDBetteridge force-pushed the JDBetteridge/fix_adjoint_notes branch from 53d1f76 to 5c3eecf Compare April 10, 2025 12:58
@JDBetteridge
Copy link
Member Author

Okay, I put it back. You fixed it upstream whilst I was lecturing

@JDBetteridge JDBetteridge merged commit 191ccf4 into master Apr 10, 2025
9 checks passed
@JDBetteridge JDBetteridge deleted the JDBetteridge/fix_adjoint_notes branch April 10, 2025 21:07
@JDBetteridge JDBetteridge mentioned this pull request Apr 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants