Open
Conversation
raghubetina
requested changes
Jan 29, 2018
spec/features/calculations_spec.rb
Outdated
| it "creates an appropriately constrained random number", points: 1, hint: h("exclusive_random_numbers") do | ||
| visit "/flexible/random/1/10" | ||
|
|
||
| reg_exp = /A random number between 1 and 10 is (\d+)/ |
Contributor
There was a problem hiding this comment.
Perhaps naming reg_exp something like pattern?
|
|
||
| reg_exp = /A random number between 1 and 10 is (\d+)/ | ||
| matched_groups = reg_exp.match(page.text) | ||
| first_matched_number = matched_groups[1].to_i |
Contributor
There was a problem hiding this comment.
Can we call #second here rather than #[1]?
If not, can we do .at(1)?
Contributor
Author
There was a problem hiding this comment.
Unfortunately, need to stick with [] syntax
spec/features/calculations_spec.rb
Outdated
| reg_exp = /A random number between 1 and 10 is (\d+)/ | ||
| matched_groups = reg_exp.match(page.text) | ||
| first_matched_number = matched_groups[1].to_i | ||
| expect(first_matched_number).to be > 1 |
Contributor
There was a problem hiding this comment.
Do we need to check (either here or in a separate spec) that it's also less than 10?
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just need a once-over to make sure we're on the same page with naming conventions and that the flexible random numbers specs are readable enough.