Skip to content
This repository was archived by the owner on Feb 10, 2026. It is now read-only.

feat: add option to configure display name of ios screen broadcast extension#527

Merged
MiloszFilimowski merged 1 commit intofishjam-cloud:mainfrom
DarvilCZE:darvilcze/sbe-display-name
Dec 11, 2025
Merged

feat: add option to configure display name of ios screen broadcast extension#527
MiloszFilimowski merged 1 commit intofishjam-cloud:mainfrom
DarvilCZE:darvilcze/sbe-display-name

Conversation

@DarvilCZE
Copy link
Contributor

Description

This PR adds the option to configure the display name of the extension. This display name is shown in the native pop-up after starting to share the screen.

Motivation and Context

Currently, our app shows FishjamScreenBroadcast in the native popup, which can be confusing for our users, as they have no idea what Fishjam is.

Documentation impact

I am not sure about this. I didn't find any related documentation to update. Similar to tests, I have tested it in the internal/fishjam-chat by running prebuild and checking the Info.plist file manually.

  • Documentation update required
  • Documentation updated in another PR
  • No documentation update required

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)

@MiloszFilimowski MiloszFilimowski self-requested a review December 11, 2025 11:13
@MiloszFilimowski MiloszFilimowski self-assigned this Dec 11, 2025
@MiloszFilimowski
Copy link
Collaborator

Hello @DarvilCZE, thank you for your contribution. I tested the changes and it works perfectly 👍

I'll merge the PR now.

@MiloszFilimowski MiloszFilimowski merged commit a5cfe3f into fishjam-cloud:main Dec 11, 2025
4 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments