This repository was archived by the owner on Feb 10, 2026. It is now read-only.
feat: add option to configure display name of ios screen broadcast extension#527
Merged
MiloszFilimowski merged 1 commit intofishjam-cloud:mainfrom Dec 11, 2025
Conversation
Collaborator
|
Hello @DarvilCZE, thank you for your contribution. I tested the changes and it works perfectly 👍 I'll merge the PR now. |
MiloszFilimowski
approved these changes
Dec 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the option to configure the display name of the extension. This display name is shown in the native pop-up after starting to share the screen.
Motivation and Context
Currently, our app shows
FishjamScreenBroadcastin the native popup, which can be confusing for our users, as they have no idea what Fishjam is.Documentation impact
I am not sure about this. I didn't find any related documentation to update. Similar to tests, I have tested it in the
internal/fishjam-chatby running prebuild and checking theInfo.plistfile manually.Types of changes
not work as expected)