Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the OpenAPI client models to reflect API changes and fixes test expectations accordingly. The main changes include introducing a structured Subscriptions model to replace a simple list, adding a ConflictError exception class, and updating the Stream model with a new field.
- Replaced
subscriptionsfromlist[str]to a structuredSubscriptionsobject with separatepeersandtrackslists - Added
ConflictErrorexception handling for HTTP 409 responses (previously treated asServiceUnavailableError) - Added
connected_viewersfield to theStreammodel
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/test_room_api.py | Updated test assertions to use new Subscriptions model and corrected exception type from ServiceUnavailableError to ConflictError |
| fishjam/errors.py | Added ConflictError exception class and HTTP 409 status code handling |
| fishjam/_openapi_client/models/subscriptions.py | New model file defining the Subscriptions class with peers and tracks fields |
| fishjam/_openapi_client/models/stream.py | Added connected_viewers field to track the number of connected viewers |
| fishjam/_openapi_client/models/peer.py | Changed subscriptions attribute type from list[str] to Subscriptions object |
| fishjam/_openapi_client/models/init.py | Exported the new Subscriptions model |
| fishjam/_openapi_client/api/room/add_peer.py | Added handling for HTTP 409 (Conflict) responses |
| docker-compose-test.yaml | Removed unused SIP and components configuration, and removed volume mount for test fixtures |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ostatni5
approved these changes
Nov 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates openapi and fixes tests, unfortunately, until https://linear.app/swmansion/issue/FCE-2393/fishjam-webhooks is fixed tests won't pass.
Motivation and Context
Why is this change required? What problem does it solve? If it fixes an open
issue, please link to the issue here.
Documentation impact
Types of changes
not work as expected)