Install optional dependencies on docs generation#59
Merged
PiotrWodecki merged 1 commit intomainfrom Dec 12, 2025
Merged
Conversation
czerwiukk
approved these changes
Dec 12, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a documentation generation failure by ensuring optional dependencies (specifically the Gemini integration) are installed during the docs build process. The fishjam/integrations/gemini.py module requires the google-genai package, which is defined as an optional dependency. When pdoc attempts to generate documentation, it imports all modules including this integration, causing the build to fail without the optional dependencies.
- Updates both documentation workflow files to install all extras and dev dependencies
- Aligns the documentation workflows with the existing CI workflow pattern
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.github/workflows/tag_docs.yml |
Adds --all-extras --dev --all-packages flags to uv sync command to install optional dependencies needed for docs generation |
.github/workflows/main_docs.yml |
Adds --all-extras --dev --all-packages flags to uv sync command to install optional dependencies needed for docs generation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue where docs generation needs the newly added optional Gemini dependency.
Documentation impact
Types of changes
not work as expected)