Conversation
|
Download links |
There was a problem hiding this comment.
Pull request overview
This PR wires up Expo Application Services (EAS) build and submission for the fishjam-chat mobile example, and switches the React Native WebRTC dependency from a Git commit to a published npm version to support the new build pipeline.
Changes:
- Move
@fishjam-cloud/react-native-webrtcfrom a GitHub commit reference to the npm-published0.25.0and update the lockfile accordingly. - Add EAS-related configuration and scripts for the
examples/mobile-client/fishjam-chatapp (eas.json, updatedapp.json, and neweas-build-pre-install/prebuildscripts). - Introduce a GitHub Actions workflow (
mobile_eas_build.yaml) that, on labeled PRs, builds the mobile app via EAS, submits the iOS build to TestFlight, and comments build links on the PR.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
yarn.lock |
Updates lockfile entry to use @fishjam-cloud/react-native-webrtc from npm at version 0.25.0 instead of a GitHub commit. |
packages/mobile-client/package.json |
Points the mobile client package to @fishjam-cloud/react-native-webrtc version 0.25.0 from npm, aligning with the new lockfile entry. |
examples/mobile-client/fishjam-chat/package.json |
Adds EAS build hook scripts (eas-build-pre-install, prebuild) to install deps, build the monorepo, and clean/prebuild native projects before EAS runs. |
examples/mobile-client/fishjam-chat/eas.json |
Introduces EAS CLI/build/submit configuration, including build profiles and App Store Connect app ID for production submission. |
examples/mobile-client/fishjam-chat/app.json |
Adjusts iOS and Android bundle identifiers, adds encryption declaration, and configures EAS extras for project ID and the iOS Screen Broadcast extension. |
.github/workflows/mobile_eas_build.yaml |
Adds a PR-label-triggered macOS workflow that runs EAS build for both platforms, submits the iOS build to TestFlight, and posts PR comments with build metadata and download links. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 8 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 9 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Download links |
Description
Motivation and Context
Documentation impact
Types of changes
not work as expected)