Add serialization support (while still keeping backwards compatibility)#8
Open
aasaru wants to merge 1 commit intofizzed:masterfrom
Open
Add serialization support (while still keeping backwards compatibility)#8aasaru wants to merge 1 commit intofizzed:masterfrom
aasaru wants to merge 1 commit intofizzed:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I propose adding serialization support to PDU-s. I have tested it and it worked fine.
User can still break serialization by adding non-serializable object to a PDU using setReferenceObject(). It would be possible to change the method signature for this method so it would take only a serializable parameter but this would break backwards compatibility so I just added a comment.
The other way would be to deprecate current method and add new method, something like this:
/**
* @deprecated Replaced by {@link #setReference(Object)}
*/
@deprecated
public void setReferenceObject(Object value) {
this.referenceObject = value;
}