Skip to content
This repository was archived by the owner on Jan 27, 2018. It is now read-only.

Dev jonas#39

Open
poehlerj wants to merge 8 commits intofknorr:masterfrom
poehlerj:dev-jonas
Open

Dev jonas#39
poehlerj wants to merge 8 commits intofknorr:masterfrom
poehlerj:dev-jonas

Conversation

@poehlerj
Copy link

This pull request change the parser implementation to an implementation with Beautiful Soup. This means that about half of the parser.py was thrown out.
I also accidentally slipped and fell on the PyCharm formatter. Sorry for that

Copy link

@N-Coder N-Coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still needs a lot of work.

What still needs to be done?
@fknorr said that the parsing of the file tree is still not working, because the whole tree is no longer displayed on one page.
Do you know more about this?

@fknorr
Copy link
Owner

fknorr commented Nov 7, 2017

Previously, each file had a details view that could be shown by clicking on the arrow left of the file name. It contained a link to each directory in the hierarchy leading to the file, so we could implement metadata fetching by parsing the "All Files" view and building the directory structure form the hierarchy information.

The old details page is now gone and was replaced by the "Information" view reachable via the dropdown right of the filename. It still contains creation date, author etc., but not the hierarchy, so we cannot reconstruct the directories.

The simplest solution is to recurse into the directory tree instead, but this would cause more requests during update which are also interdependent. To speed things up, we could first check if anything has changed by looking at the "All Files" view, then recursing into the tree until all files are mapped to their respective directories.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants