Skip to content

Use ready channel and context timeout for readiness #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
canercidam merged 9 commits into from
Jan 2, 2026
Merged

Use ready channel and context timeout for readiness #288

canercidam merged 9 commits into from
Jan 2, 2026

Conversation

@canercidam
Copy link
Contributor

@canercidam canercidam commented Jan 2, 2026

  • Using idiomatic ways (channel and context) to handle readiness and the timeout for it
  • The "never ready" or "always ready" logic in the test wasn't effective because the service readiness is ignored whenever the ReadyCheck of the service is nil. The changes surfaced this problem and the tests were fixed accordingly.

@canercidam canercidam requested a review from ferranbt as a code owner January 2, 2026 15:07
Base automatically changed from ferranbt-use-timeout-readiness to main January 2, 2026 15:28
@canercidam canercidam merged commit 94d9982 into main Jan 2, 2026
9 checks passed
@canercidam canercidam deleted the caner/use-ready-channel branch January 2, 2026 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ferranbt ferranbt ferranbt approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@canercidam @ferranbt