refactor: new 变量修改为 newConfig , 避免与内建函数 new 冲突 #1395
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ruochen <wanxialianwei@gmail.com>
kongfei605
reviewed
Jan 16, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors variable names in the caculateDiff method to improve code clarity by avoiding potential confusion with the new keyword, even though Go doesn't have such a keyword. The changes rename new to newConfig and old to oldConfig, and also add helpful comments explaining the logic.
Changes:
- Renamed variables
newandoldtonewConfigandoldConfigrespectively - Added clarifying comments about inputKey being a configmap checksum computed by the n9e server
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: ruochen <wanxialianwei@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.