Conversation
| this.openapiDocument = props.openapiDocument; | ||
| this.customResourceFunction = customResourceFunction.nodeJsFunction; | ||
|
|
||
| // TODO: check for a better way to retrieve the api id |
There was a problem hiding this comment.
I still need to validate if this will work...
flaviostutz
left a comment
flaviostutz
left a comment
There was a problem hiding this comment.
Very nice, man!
Do you believe I have a WIP on this construct that I forgot to merge? #60
I reviewed your version and compared with some things I had in my PR and they seem similar. If you have tested your version already, let's keep with your version because you added the find API by parameters options which is nice too.
My implementation was complete, but I never tested in a real Custom Resource against the WSO2 server.
Please copy the tests from my PR to yours (also there are tests for "application").
Co-authored-by: Flavio Stutz <flaviostutz@gmail.com>
I want to test it today against the real WSO2 server, so please, don't merge it yet |
| * }, | ||
| * }); | ||
| */ | ||
| export class Wso2ApiSubscription extends Construct { |
There was a problem hiding this comment.
I was wondering about this taxonomy..
At first I thought about api-subscription to be very explicit, but internally in wso2 it is only called subscription.
In your draft #60 you also called it subscription.
Shall we change the taxonomy to be subscription?
|
Hey, I'm interested in creating subscriptions using cdk-practical-constructs, and can easily test it against a real WSO2 server. How can I help out with getting this PR up to date with the latest changes in main, and merged? I think what's currently missing is that it's not possible to passing it a |
|
@MarcioMeier Could we merge this PR into feat branch "feat/wso2-subscription-marcio" so that we can generate a pre-release version for Casper to test it? |
3 participants
Summary
Adds the api subscription capabilities to the cdk practical constructs library
API Ref: https://apim.docs.wso2.com/en/3.2.0/develop/product-apis/devportal-apis/devportal-v1/devportal-v1/#tag/Subscriptions