feat: Add image support to Parchment Markdown codec#521
Draft
CesareIsHere wants to merge 1 commit intofleather-editor:masterfrom
Draft
feat: Add image support to Parchment Markdown codec#521CesareIsHere wants to merge 1 commit intofleather-editor:masterfrom
CesareIsHere wants to merge 1 commit intofleather-editor:masterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #521 +/- ##
==========================================
+ Coverage 88.69% 88.78% +0.08%
==========================================
Files 63 63
Lines 10855 10940 +85
==========================================
+ Hits 9628 9713 +85
Misses 1227 1227 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
@CesareIsHere Thank you for this PR. It is still marked as draft, is this intended? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Implements bidirectional image support for
ParchmentMarkdownCodec. Previously, images were silently dropped during Markdown encoding. Now images are preserved in both directions: Markdown ↔ Parchment.✨ What's New
!alt→BlockEmbed.image(url)BlockEmbed.image(url)→🛠️ Implementation
Decoder
_imageRegExppattern and_handleImage()methodEncoder
handleLine()to detect image embeds specificallyformat while skipping other embeds🧪 Tests Added
📋 Example
✅ Backward Compatible