Updated libreoffice and carbone components#10
Open
suddenelfilio wants to merge 3 commits intofleebzz:masterfrom
Open
Updated libreoffice and carbone components#10suddenelfilio wants to merge 3 commits intofleebzz:masterfrom
suddenelfilio wants to merge 3 commits intofleebzz:masterfrom
Conversation
fleebzz
requested changes
Feb 7, 2022
Owner
fleebzz
left a comment
fleebzz
left a comment
There was a problem hiding this comment.
Hi @suddenelfilio and thx for this PR.
You'll find some requested changes in my review.
I'm ok with new versions of node, Carbone and LO you made but I'm skeptical about what you did about the options. Can you tell me more about the issue you had before this PR ?
Author
|
Ok @fleebzz updated/reverted those changes I made for testing |
fleebzz
requested changes
Feb 15, 2022
| try { | ||
|
|
||
| data = JSON.parse(_data); | ||
| console.log(data); |
| let data = {}; | ||
|
|
||
| try { | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.