Merged
Conversation
|
robert-dean
approved these changes
Mar 24, 2025
AdamJackman
approved these changes
Mar 24, 2025
AdamJackman
left a comment
AdamJackman
left a comment
There was a problem hiding this comment.
LGTM. Also, curious if Robert's suggestion is the simpler solution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Routes with path parameters were capturing requests meant for more specific routes with literal paths.
Example:
GET /transactions/{transactionId} was capturing requests for
GET /transactions/line-transactions
Solution
Implemented a route prioritization algorithm that sorts paths by specificity:
Routes without path parameters come before routes with parameters
Routes with fewer parameters come before routes with more parameters
Routes with more segments are prioritized over routes with fewer segments
Alphabetical sorting as a tie-breaker