Skip to content
This repository was archived by the owner on Jul 11, 2022. It is now read-only.
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions core/README.txt
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ Version history:
3.2.19-dev
------
- new top level config option 'persistVolumeLevel'. Does not store the volume level and create a 'flash cookie' if set to false.
- #121 fix for XSS protocoless urls breaking the local url check. Disabled wildcard security for loading crossdomain plugin code for now as same domain does not need this.

3.2.17
------
Expand Down
3 changes: 2 additions & 1 deletion core/src/actionscript/org/flowplayer/util/URLUtil.as
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,8 @@ package org.flowplayer.util {

public static function isCompleteURLWithProtocol(fileName:String):Boolean {
if (! fileName) return false;
return fileName.indexOf("://") > 0;
//#121 check for any protocol string including the new protocoless urls
return fileName.indexOf("//") > 0;
}


Expand Down
3 changes: 2 additions & 1 deletion core/src/actionscript/org/flowplayer/view/PluginLoader.as
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,8 @@ import org.flowplayer.util.URLUtil;
_loadListener = loadListener;
_loadErrorListener = loadErrorListener;

Security.allowDomain("*");
//#121 disable this as it possibly causes issues with crossdomain code loading.
//Security.allowDomain("*");

_providers = new Dictionary();
_allPlugins = plugins.concat([]);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,8 @@ public class DomainUtil {
if (url.indexOf("file://") == 0) return true;
if (url.indexOf("http://127.0.0.1") == 0) return true;
if (url.indexOf("http://") == 0) return false;
if (url.indexOf("/") == 0) return true;
//#121 remove this check as //domain.com which is a new protocoless way to set urls bypasses this.
//if (url.indexOf("/") == 0) return true;
return false;
}

Expand Down