Open
Conversation
Member
|
Thanks for the PR and sorry for my late reply. I looked at the PR and I found that AsyncRawSocketSender.emit() and flush() create anonymous Runnable every time. It can cause a poor performance. So I think we'd better use consumer-producer model to implement async sender. What do you think? |
Author
|
sorry for the late reply. yes, performance might be an issue. but i think i'd rather let someone else do that refactoring. i am currently in the middle of a different task at work, which no longer has anything to do with AsyncRawSocketSender. |
… wrapper around RawSocketSender
added 2 commits
November 25, 2014 21:04
… wrapper around RawSocketSender
Conflicts: src/main/java/org/fluentd/logger/sender/AsyncRawSocketSender.java
Author
|
changed to nested classes. |
|
@komamitsu @mxk1235 can this PR be revived? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AsyncRawSocketSender is just a wrapper around RawSocketSender that does its work in a separate thread.
also added a factory method to create a logger with its own sender, and moved from using a synchronized method to using a synchronizedMap for the loggers.