test(pkg/ddc/juicefs): add unit tests for ufs_internal.go

[hxrshxz]

Ⅰ. Describe what this PR does

Added tests for totalStorageBytesInternal, totalFileNumsInternal, and usedSpaceInternal methods. Needed to bump coverage for the juicefs package.

Ⅱ. Does this pull request fix one issue?

part of #5407

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

• TestTotalStorageBytesInternal - handles GetRunningPodsOfStatefulSet errors, empty pods, GetUsedSpace errors, and successful calculations
• TestTotalFileNumsInternal - same pattern for file count operations
• TestUsedSpaceInternal - validates parsing of JuiceFS status command output

All use Convey since that's what the existing tests in this file use.

Ⅳ. Describe how to verify it

go test ./pkg/ddc/juicefs/... -v -cover

[fluid-e2e-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign trafalgarzzz for approval by writing /assign @trafalgarzzz in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[fluid-e2e-bot]

Hi @hxrshxz. Thanks for your PR.

I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[gemini-code-assist]

Summary of Changes

Hello @hxrshxz, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces unit tests for several internal methods within the JuiceFS engine related to storage and file statistics. It aims to improve the overall test coverage of the JuiceFS package by adding tests that simulate various success and failure scenarios when interacting with the Kubernetes API and JuiceFS file system.

Highlights

• Unit Tests: This PR adds unit tests for the totalStorageBytesInternal, totalFileNumsInternal, and usedSpaceInternal methods in the JuiceFS engine.
• Coverage: The primary goal is to increase the test coverage for the JuiceFS package.
• Error Handling: The tests cover scenarios including errors when getting running pods, empty pod lists, and failures when retrieving used space or file counts.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces comprehensive unit tests for the totalStorageBytesInternal, totalFileNumsInternal, and usedSpaceInternal methods within the pkg/ddc/juicefs package. The new test file ufs_internal_test.go utilizes gomonkey for mocking dependencies like GetRunningPodsOfStatefulSet, GetUsedSpace, and GetFileCount, and goconvey for structuring test scenarios. The tests cover critical edge cases such as errors during pod retrieval, empty pod lists, and errors during space/file count operations, as well as successful execution paths, significantly improving the test coverage for these internal utility functions.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.78%. Comparing base (6b4ab6b) to head (0dba9ae).

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5479      +/-   ##
==========================================
+ Coverage   56.76%   56.78%   +0.01%     
==========================================
  Files         443      443              
  Lines       30735    30735              
==========================================
+ Hits        17447    17453       +6     
+ Misses      11734    11730       -4     
+ Partials     1554     1552       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
34.0% Duplication on New Code

See analysis details on SonarQube Cloud