-
Notifications
You must be signed in to change notification settings - Fork 0
Feat/add subscription related charts #97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Add three new ChartCardId enum values for subscriptions management: - subscriptionsActiveOverTime: Line chart for active subscribers trend - subscriptionsStatusDistribution: Bar chart for subscription status breakdown - subscriptionsByStoreProvider: Bar chart for subscriptions distribution by store (Apple vs. Google)
- Add new enum values for active, canceled, and expired subscriptions KPI cards - Introduce new section in the KpiCardId enum for subscriptions management page
- Add three new chart cards for subscription management: - Active subscriptions over time - Subscription status distribution - Subscriptions by store provider - Implement data generation for different time frames (week, month, year) - Update chart labels in multiple languages
- Added fixtures for active, canceled, and expired subscriptions KPI cards - Included data for different time frames (day, week, month, year) - Updated labels in English and Arabic
- Update the expected length of ChartCardId.values from 21 to 24 - This change reflects an increase in the number of enum values
- Update test to expect 24 values instead of 21 - This change reflects an increase in the number of KpiCardId enum values
- Rename `usersRoleDistribution` to `usersTierDistribution` in ChartCardId enum - Update chart card data and labels to reflect new user tier distribution naming - Add 'Guest' tier to the categorical series for weekly, monthly, and yearly data
- Add new analytics payloads for subscription events and access tier changes - Implement dashboard KPIs and charts for subscription management - Refactor User model to use AccessTier for entitlements and UserRole for administrative permissions - Update configuration models to use AccessTier as the key for role-based settings - Separate UserContext from User model for cleaner identity and interaction state management - Update analytics to reflect new AccessTier monetization model
Summary of ChangesHello @fulleni, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the analytics dashboard by introducing a comprehensive set of charts and Key Performance Indicators (KPIs) specifically designed for subscription management. It also refactors existing user distribution analytics to reflect 'AccessTier' rather than 'AppUserRole', ensuring consistency with recent monetization model changes. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces new analytics charts and KPIs for subscription management. The changes are well-structured, adding new enums, fixture data, and updating corresponding tests and generated files. The refactoring from usersRoleDistribution to usersTierDistribution is also consistently applied. I've added one comment regarding code duplication in the fixture data to improve maintainability. Overall, this is a solid contribution.
Status
READY
Description
This pull request significantly enhances the analytics dashboard by introducing a comprehensive set of charts and Key Performance Indicators (KPIs) specifically designed for subscription management. It also refactors existing user distribution analytics to reflect 'AccessTier' rather than 'AppUserRole', ensuring consistency with recent monetization model changes.
Type of Change