Replace Ecore Queue with Message Loop#155
Replace Ecore Queue with Message Loop#155xiaowei-guan wants to merge 9 commits intoflutter-tizen:masterfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request replaces the Ecore queue with a custom MessageLoop class using standard C++ threading primitives. This is a positive change that reduces external dependencies. The new implementation is largely correct, but I have identified a few areas for improvement regarding safety, code clarity, and structure. My review includes suggestions to refactor the MessageLoop initialization to make it safer, improve a lambda capture for better robustness, and enhance code organization by moving the new general-purpose class to its own files.
There was a problem hiding this comment.
Code Review
This pull request replaces the Ecore-based thread queue in TizenVsyncWaiter with a custom MessageLoop class implemented using standard C++ threading primitives, which improves portability and maintainability by removing a dependency on Ecore. However, a critical regression was identified: a previously existing validation check for the TDM client state was removed. This omission could lead to an application crash if the TDM subsystem fails to initialize correctly. Additionally, there is a suggestion to further align the new MessageLoop class with the project's C++ style guidelines.
2 participants
Fix #149