Skip to content

Fix composingExtent parsing in setEditingState #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JSUYA merged 3 commits into from
Feb 13, 2026
Merged

Fix composingExtent parsing in setEditingState #156

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d049b7a
Fix composingExtent parsing in setEditingState
JSUYA Feb 12, 2026
7379e40
Add mising return
JSUYA Feb 12, 2026
9a104bf
Merge branch 'master' into fix_seteditingstate
JSUYA Feb 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion flutter/shell/platform/tizen/channels/text_input_channel.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,7 @@ void TextInputChannel::HandleMethodCall(
if (client_config.IsNull()) {
result->Error(kBadArgumentError,
"Could not set client, missing arguments.");
return;
}

client_id_ = client_id_json.GetInt();
Expand Down Expand Up @@ -257,7 +258,7 @@ void TextInputChannel::HandleMethodCall(
TextRange(selection_base_value, selection_extent_value));

auto composing_base = args.FindMember(kComposingBaseKey);
auto composing_extent = args.FindMember(kComposingBaseKey);
auto composing_extent = args.FindMember(kComposingExtentKey);
int composing_base_value = composing_base != args.MemberEnd()
? composing_base->value.GetInt()
: -1;
Expand Down