[video_player_avplay/videohole] Remove unused proxy apis#961
[video_player_avplay/videohole] Remove unused proxy apis#961JSUYA merged 3 commits intoflutter-tizen:masterfrom
Conversation
There was a problem hiding this comment.
Code Review
This pull request removes the unused ecore_wl2_window_surface_id_get function and its declaration from both the video_player_avplay and video_player_videohole packages. This change leaves an unused typedef in the corresponding .cc files that should also be removed. Additionally, I've suggested minor improvements to the changelog entries for better readability and consistency.
I am having trouble creating individual review comments. Click here to see my feedback.
packages/video_player_avplay/CHANGELOG.md (4)
For better clarity and to follow common changelog conventions, it's recommended to use the past tense and capitalize the acronym 'API'.
* Removed unused proxy APIs.
packages/video_player_avplay/tizen/src/ecore_wl2_window_proxy.cc (40-53)
With the removal of this function, the corresponding typedef FuncEcoreWl2WindowSurfaceIdGet at line 13 is no longer used and should also be removed to maintain code cleanliness.
packages/video_player_videohole/CHANGELOG.md (4)
For better clarity and to follow common changelog conventions, it's recommended to use the past tense and capitalize the acronym 'API'.
* Removed unused proxy APIs.
packages/video_player_videohole/tizen/src/ecore_wl2_window_proxy.cc (40-53)
With the removal of this function, the corresponding typedef FuncEcoreWl2WindowSurfaceIdGet at line 13 is no longer used and should also be removed to maintain code cleanliness.
Remove ecore_wl2_window_surface_id_get() because it is unused.