Add --oci-skip-registry-validation flag for custom registry proxies
#1083
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for using custom OCI registry proxies/gateways with cloud provider workload identity authentication by introducing a new controller flag that bypasses registry domain validation.
Problem
Organizations using custom OCI registry proxies (for security, caching, or compliance reasons) cannot use cloud provider authentication because the auth package validates that registry domains match official patterns (e.g.,
*.gcr.io,*.dkr.ecr.*.amazonaws.com,*.azurecr.io).Solution
Add a new controller flag
--oci-skip-registry-validationthat, when enabled, skips domain validation inParseArtifactRepositoryfor all cloud providers (GCP, AWS, Azure).Changes
auth/controller_flags.goControllerFlagOCISkipRegistryValidationociSkipRegistryValidationvariableSetOCISkipRegistryValidation()andGetOCISkipRegistryValidation()functionsauth/gcp/provider.goParseArtifactRepositoryto skip validation when flag is enabledauth/aws/provider.goParseArtifactRepositoryto skip validation when flag is enabledgetECRRegionFromRegistryInputto fall back toAWS_REGIONenv var when provider name is returnedauth/azure/provider.goParseArtifactRepositoryto skip validation when flag is enabledTests
Added tests for:
TestSetOCISkipRegistryValidationTestGetOCISkipRegistryValidationTestProvider_ParseArtifactRegistry_SkipValidation(GCP)TestProvider_ParseArtifactRepository_SkipValidation(AWS)TestProvider_ParseArtifactRegistry_SkipValidation(Azure)Usage
Controllers using this package can bind the flag:
Security Considerations
Related