Testing notifications - Do not merge #1
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…(to lower precision) in two different places. Also found and removed a couple of redundant definitions of GAUSS_K and SOLAR_GM.
…hould have counted characters.
…-plus-six-hex-digits. Also, MSVC lacks an 'ssize_t' type. Fortunately, a little re-ordering removes the need for one.
…pdating. Added a comment in 'header.htm' (English version) to remind me that if you modify that file, you need to check those for other languages to see if they need similar alterations.
… version constant to 2024 Aug 11.
…ad of P/nnn. That causes some minor changes in how we read comet names from ELEMENTS.COMET.
…Abdelaziz Moursi. (I think ObsCodes.htm may have the same corrections soon.) Also, three new obscodes from ObsCodes.htm.
…tive Find_Orb. We have better ways of doing it now.
…ion). Updated the version info.
… on Windows and/or systems where you might have the code stored someplace other than in a 'find_orb' directory immediately underneath the home directory.
… observer details.
…boxes (which don't have a '~' = home directory concept), but should remain ~ on other platforms.
… been generalized off-earth, and lunicentric ephems always showed objects as being blocked by the moon.
…our characters long. Reported by Alex Gibbs.
…tion is beyond a 'reasonable' length (same criteria used as for Herget steps)
…ind 'piece' files and didn't unlink temporary files
…as a 'temp' variable elsewhere
…nd nominal_rv variables in debug builds. In non-debug builds, the optimizer recognizes that those variables will inevitably be set, but debug builds skip that procedure. I also realized that 'computer friendly' (high precision) residuals would overflow the buffer if abs(resid)>=10 arcseconds; the text is now truncated correctly, without producing an error.
…pe, instead of a cryptic array of seven doubles. No effect on the output (yet), but it makes the code more readable and will help in future work.
… now shows that date/time in MJD or JD form.
…b had an off-by-one problem. You'd click on a desired obscode, and get a different one instead.
…lly being used to show designations or whatever happened to be in columns 57-65 of the original MPC report. Now labels said column correctly.
…icentric (or any place on the moon), show earth elongation instead.
The Horizons commentary for this quantity specifies that it is positive if the observer is above the orbit plane and negative if below. That means the quantity must flip sign for a retrograde orbit. Odd, but easy to accommodate. Man-To Hui pointed out the error, and also noticed that even after this fix, PlAng for C/2024 S1 (Kreutz sungrazer) differs from Horizons by as much as three degrees. Still investigating this.
…language's language
…bably others, have been observed by more than that.
…, minor axis, correlation) into ADES form (sigRA, sigDec, correlation). This will help both in checking correctness of uncertainty handling, and (eventually) in outputting ADES data.
…ncertainty ellipse is rounded correctly, not just truncated
…inties. For correlated RA/dec errors, this shows the uncertainties both in elliptical (major axis, minor axis, and position angle) form, _and_ in ADES form (rmsRA, rmsDec, rmsCorr).
…on and the magnitude, and information about the astrometric uncertainty for that observation will be shown
…ly once upon a time?)
…unately, only mattered in unusual cases involving mixed ADES and 80-column observations of different objects... but I encountered such a case.)
…s were set so as to allow that. Unusual in most systems, but not on Microsoft Windows.
…fferent one for other OSes.
…the distant past?)
…lumn single-character band 'j'. I'm assuming Vj = V for our humble purposes. MPC is, I gather, attempting to sort this out.
…. Fortunately, an edge case very rarely triggered... still, it was wrong.
…nds, it is considered a 'dec only' or 'RA only' observation, of the sort commonly made in the 19th century or earlier. The 'unobserved' axis is omitted on-screen.
…re, and now found in 'constant.h')
…retired. The SWFO-L1 spacecraft now has unofficial code (SWF). There are four new terrestrial codes and two with position tweaks. Also updated the version date.
…onfused into considering only one. Also, there are now six spacecraft that might report sungrazer data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.