Skip to content

Support --ignore-chunks option to 'prune' command #301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
folbricht wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Support --ignore-chunks option to 'prune' command #301

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 24 additions & 5 deletions cmd/desync/prune.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,21 +12,28 @@ import (

type pruneOptions struct {
cmdStoreOptions
store string
yes bool
store string
yes bool
ignoreChunks []string
}

func newPruneCommand(ctx context.Context) *cobra.Command {
var opt pruneOptions

cmd := &cobra.Command{
Use: "prune <index> [<file>..]",
Use: "prune [<index> ...]",
Short: "Remove unreferenced chunks from a store",
Long: `Read chunk IDs in from index files and delete any chunks from a store
that are not referenced in the provided index files. Use '-' to read a single index
from STDIN.`,
from STDIN. Alternatively, chunk IDs can be provided in a text file with
--ignore-chunks <file>.`,
Example: ` desync prune -s /path/to/local --yes file.caibx`,
Args: cobra.MinimumNArgs(1),
Args: func(cmd *cobra.Command, args []string) error {
if len(args) == 0 && len(opt.ignoreChunks) == 0 {
return errors.New("required at least one index file or --ignore-chunks argument")
}
return nil
},
RunE: func(cmd *cobra.Command, args []string) error {
return runPrune(ctx, opt, args)
},
Expand All @@ -35,6 +42,7 @@ from STDIN.`,
flags := cmd.Flags()
flags.StringVarP(&opt.store, "store", "s", "", "target store")
flags.BoolVarP(&opt.yes, "yes", "y", false, "do not ask for confirmation")
flags.StringSliceVarP(&opt.ignoreChunks, "ignore-chunks", "", nil, "additional chunk IDs to keep from text file(s)")
addStoreOptions(&opt.cmdStoreOptions, flags)
return cmd
}
Expand Down Expand Up @@ -78,6 +86,17 @@ func runPrune(ctx context.Context, opt pruneOptions, args []string) error {
}
}

// Read chunk IDs from text files
for _, f := range opt.ignoreChunks {
chunkIDs, err := readChunkIDFile(f)
if err != nil {
return err
}
for _, id := range chunkIDs {
ids[id] = struct{}{}
}
}

// If the -y option wasn't provided, ask the user to confirm before doing anything
if !opt.yes {
fmt.Printf("Warning: The provided index files reference %d unique chunks. Are you sure\nyou want to delete all other chunks from '%s'?\n", len(ids), s)
Expand Down