Skip to content

Write index file even if --print-stats is used with 'make' #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
folbricht merged 1 commit into from
Feb 8, 2026
Merged

Write index file even if --print-stats is used with 'make' #308

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cmd/desync/make.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ to STDOUT.`,
flags := cmd.Flags()
flags.StringVarP(&opt.store, "store", "s", "", "target store")
flags.StringVarP(&opt.chunkSize, "chunk-size", "m", "16:64:256", "min:avg:max chunk size in kb")
flags.BoolVarP(&opt.printStats, "print-stats", "", false, "print chunking statistics and exit without writing the index file")
flags.BoolVarP(&opt.printStats, "print-stats", "", false, "print chunking statistics to stderr when done")
addStoreOptions(&opt.cmdStoreOptions, flags)
return cmd
}
Expand Down Expand Up @@ -81,7 +81,7 @@ func runMake(ctx context.Context, opt makeOptions, args []string) error {
}
}
if opt.printStats {
return printJSON(stderr, stats) // write to stderr since stdout could be used for index data
printJSON(stderr, stats) // write to stderr since stdout could be used for index data
}
return storeCaibxFile(index, indexFile, opt.cmdStoreOptions)
}
Expand Down