feat(main): add user defined condition before saving session#105
Draft
AndreJesusBrito wants to merge 2 commits intofolke:mainfrom
Draft
feat(main): add user defined condition before saving session#105AndreJesusBrito wants to merge 2 commits intofolke:mainfrom
AndreJesusBrito wants to merge 2 commits intofolke:mainfrom
Conversation
AndreJesusBrito
force-pushed
the
conditional-session-save
branch
from
260ed70 to
55956ea
Compare
AndreJesusBrito
changed the title
|
+1. We need a way to selectively save a session, not saving all the time. |
AndreJesusBrito
force-pushed
the
conditional-session-save
branch
from
55956ea to
d2d5dc3
Compare
github-actions
bot
added
size/s
AndreJesusBrito
force-pushed
the
conditional-session-save
branch
from
4d90028 to
6e79776
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a new option called "condition" that accepts a predicate function.
If it returns true then the session is saved, if not it is not saved.
This gives users flexibility to decide when they want the sessions to be saved or not.
Related Issue(s)
N/A
Screenshots
N/A
PS. I haven't worked with lua that much so feel free to do/suggest improvements.