General fixes to ensure integrity and progresses on the UI#23
Merged
Mattia-Marino merged 98 commits intomainfrom Jan 17, 2025
Merged
General fixes to ensure integrity and progresses on the UI#23Mattia-Marino merged 98 commits intomainfrom
Mattia-Marino merged 98 commits intomainfrom
Conversation
Now all current responses of deleteProject will return a map as body, in order to adhere to JSON format
Now deleting a project also deletes the reference in the users and deletes the associated teams and artifacts. Still necessary to delete the tags though, but it might be handled when deleting the artifacts. Still it would be nice to do another check here
In the method validateProject is now returned a list of missing emails as a message of error whenever someone tries to add e-mails currently not associated with any user.
t'appost
- Modified Artifact model by including an optional field "description", removed the "content" attribute and added projectId, teamId and filePath where it will be stored - Modified DTO to create an artifact to properly match the new Artifact model. It will include the optional description, removed content and added project ID and file to be saved - Added new method saveFile in ArtifactService, that will handle properly the save of the file in the local database and create the proper file path. Temporarily removed methods to create and update the artifact, and removed permanently validateArtifact - Temporarily commented out the code of ArtifactMapper and ArtifactTest
Changed the name of some parameters of project that created confusion
- Implemented the method to create an artifact in ArtifactService - Added artifactIds attribute to Team - Commented out broken team tests
Finally brought to a proper working state the creation of an artifact. Artifacts will be stored in the directory "artifacts/" located in the root of the project. Here every file will start with a unique name. The file metadata instead will be stored in MongoDB in the apposite collection. Also did some small fixes on GmailService and to the setup scripts, to put some space here and there and to handle correctly the presence of an already existing setup.zip folder when copying the secrets from the project.
token validation check was moved from the javascript file token-validation.js to nav-bar-logic.js. everytime the navbar gets loaded, the token gets checked. token-validation.js was restored
New implementation of the project update method. Still needs some fixes and polishing, but we're getting there. Also, the method addArtifact in ProjectService has been deleted, as a method who does that job has already been created in ArtifactService.
- Fixed the implementation of project update, to avoid useless computation. Can still benefict from some more checks and functionalities, but it is in a working state. - Changed endpoints of project, got rid of some annoying discrepancies in endpoint names
Implemented the method to get the artifact metadata and moved WholeArtifactDto to the proper mapper
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.