Fix Github Actions PR event checks.#2661
Merged
brandonpage merged 2 commits intoforcedotcom:devfrom Jan 30, 2025
Merged
Conversation
brandonpage
commented
Jan 30, 2025
| pull_request_target: | ||
| branches: | ||
| - dev | ||
| branches: [dev, master] |
Contributor
Author
There was a problem hiding this comment.
CI should run on master too. See this discussion.
wmathurin
approved these changes
Jan 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a
is_prinput parameter to our reusable-workflow. The value ofgithub.event_namechanges frompull_request(or however the original flow started) toworkflow_callin the reusale-workflow since that is technically how the reusable-workflow was triggered.CI will fail because it runs the workflow file on
dev. Tested here.