Skip to content
This repository was archived by the owner on Jul 21, 2025. It is now read-only.

Library construction changes#31

Open
mj-mueller wants to merge 4 commits intomasterfrom
libraryChanges
Open

Library construction changes#31
mj-mueller wants to merge 4 commits intomasterfrom
libraryChanges

Conversation

@mj-mueller
Copy link
Collaborator

The only library that will be created is 'SiteGenesisSharedLibrary'. That library
consists of the default SiteGenesis library plus generated comdagen folders and
content assets. If the summary content asset is rendered then the home-main slot
will display it. Therefore slots.xml are rendered by its own template. Library tests
are adjusted.

@salesforce-cla
Copy link

salesforce-cla bot commented Jul 8, 2019

Thanks for the contribution! Unfortunately we can't verify the commit author(s): Moritz Müller <m***@s***.com>. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, refresh the status of this Pull Request.

The only library that will be creartred is 'SiteGenesisSharedLibrary'. That
library consists of the default SiteGenesis library plus generated
comdagen folders and contentassets.

Signed-off-by: Moritz Mueller <m.mueller@salesforce.com>
If the summary content asset is rendered the home-main slot will display it. Therefore slots.xml are rendered by its own template. Tests are not finished by now and currently fail.

Signed-off-by: Moritz Mueller <m.mueller@salesforce.com>
Signed-off-by: Moritz Mueller <m.mueller@salesforce.com>
Signed-off-by: Moritz Mueller <m.mueller@salesforce.com>
Copy link
Contributor

@wundrian wundrian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice commenting!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants