Conversation
madhur310
commented
Sep 5, 2025
mshanemc
reviewed
Sep 5, 2025
mshanemc
reviewed
Sep 5, 2025
mshanemc
reviewed
Sep 5, 2025
mshanemc
reviewed
Sep 5, 2025
mshanemc
reviewed
Sep 5, 2025
mshanemc
reviewed
Sep 5, 2025
mshanemc
reviewed
Sep 5, 2025
mshanemc
reviewed
Sep 5, 2025
mshanemc
reviewed
Sep 5, 2025
mshanemc
reviewed
Sep 5, 2025
mshanemc
reviewed
Sep 5, 2025
mshanemc
reviewed
Sep 5, 2025
mshanemc
reviewed
Sep 5, 2025
mshanemc
reviewed
Sep 5, 2025
mshanemc
reviewed
Sep 5, 2025
mshanemc
reviewed
Sep 5, 2025
mshanemc
reviewed
Sep 5, 2025
mshanemc
reviewed
Sep 5, 2025
madhur310
requested review from
mshanemc
and removed request for
klewis-sfdc
mshanemc
requested changes
Sep 9, 2025
Contributor
mshanemc
left a comment
mshanemc
left a comment
There was a problem hiding this comment.
mostly the fs-utils is the problem,
I know cleanup can be a bottomless pit, but I'm kinda looking at this as an educational opportunity and bar-setting exercise.
mshanemc
reviewed
Sep 10, 2025
| "@typescript-eslint/semi": "off", | ||
| "@typescript-eslint/no-explicit-any": "off", | ||
| "@typescript-eslint/no-unused-vars": "error", | ||
| "func-style": ["error", "expression"], |
Contributor
Author
There was a problem hiding this comment.
+1 I like the const = way much better, easier to read imo and find unused stuff..
mshanemc
approved these changes
Sep 10, 2025
| removeFile(codeWorkspacePath); | ||
| removeFile(launchPath); | ||
| removeFile(tsconfigPathForce); | ||
| fs.rmSync(jsconfigPathGlobal, { recursive: true, force: true }); |
Contributor
There was a problem hiding this comment.
recursive isn't necessary for files, but it probably doesn't hurt anything?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Reduces the size and extracts out stuff out of common package. This should lead to easier to moving of code across the package.
What issues does this PR fix or reference?
@W-19442343@