fix: prefer conts/types over enums in LLS: W-19346529#619
Merged
Conversation
mshanemc
reviewed
Sep 11, 2025
mshanemc
approved these changes
Sep 12, 2025
Contributor
mshanemc
left a comment
mshanemc
left a comment
There was a problem hiding this comment.
approved but you need to fix some exports
Unused exported types (2)
TagType type packages/lightning-lsp-common/src/indexer/tagInfo.ts:5:13
Token type packages/lwc-language-server/src/lwc-server.ts:49:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updates code to prefer const/types over enums in LLS
What issues does this PR fix or reference?
@W-19346529@