Conversation
madhur310
requested review from
daphne-sfdc
and removed request for
daphne-sfdc
mshanemc
approved these changes
Sep 12, 2025
Contributor
mshanemc
left a comment
mshanemc
left a comment
There was a problem hiding this comment.
just one question, otherwise LGTM
Contributor
There was a problem hiding this comment.
what happened here? they were all unused?
Contributor
Author
There was a problem hiding this comment.
Yeah, unused and not implemented. Just voided methods like:
export async function getLibFile(file, library) {
return;
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixing all the lint issues and making lint mandatory for all packages for commit.
What issues does this PR fix or reference?
@W-19620016@