fix: prevent publish test-workspaces W-19605327#624
Conversation
madhur310
requested review from
RitamAgrawal and
mshanemc
and removed request for
RitamAgrawal
There was a problem hiding this comment.
Huh. We don't normally use npmignore. The normal approach is to have a files property on the package.json that says what files go in, instead of trying to explicitly ignore files.
There was a problem hiding this comment.
I'd rather have "e2e failed because you forgot to put something in package.json#files" rather than, "you accidentally package unnecessary stuff because you didn't put it in the .npmignore file"
| "extensions.ignoreRecommendations": true, | ||
| "salesforcedx-vscode-lightning.activationMode": "always", | ||
| "salesforcedx-vscode-lightning.showLightningExplorer": true, | ||
| "salesforcedx-vscode-core.internal-development": true |
There was a problem hiding this comment.
are these sneaking in from writing base-context?
lightning-language-server/packages/lightning-lsp-common/src/base-context.ts
Lines 261 to 262 in aaadd02
There was a problem hiding this comment.
maybe we're missing some kind of check to verify that you're working in the salesforce internal repo that all this supports?
There was a problem hiding this comment.
the big problem with making changes is that we don't test that scenario at all (using ext for internal development) but there's probably users that need it.
|
closing after further discussion offline, we will be moving things to mono repo anyways. |
2 participants
What does this PR do?
What issues does this PR fix or reference?
@W-19605327@