Skip to content

Update preferences UI #465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jmmaranan merged 3 commits into from
Aug 15, 2025
Merged

Update preferences UI #465

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fc2ba13
update spin button row style
PhilippKosarev Jun 21, 2025
18bcc42
update radio row style
PhilippKosarev Jun 21, 2025
7181b0f
remove hexpand from SpinButton of SpinButtonRow
PhilippKosarev Jun 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/prefs/settings.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ export class SettingsPage extends PreferencesPage {
title: _("Logger"),
children: [
new DropDownRow({
title: _("Logger Level"),
title: _("Log level"),
settings,
bind: "log-level",
items: Object.entries(Logger.LOG_LEVELS).map(([name, id]) => ({ id, name })),
Expand Down
6 changes: 4 additions & 2 deletions lib/prefs/widgets.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ export class SpinButtonRow extends Adw.ActionRow {
}) {
super({ title, subtitle });
const gspin = Gtk.SpinButton.new_with_range(low, high, step);
gspin.valign = Gtk.Align.CENTER;
gspin.xalign = 1;
if (bind && settings) {
settings.bind(bind, gspin, "value", Gio.SettingsBindFlags.DEFAULT);
} else if (init) {
Expand All @@ -97,6 +97,7 @@ export class SpinButtonRow extends Adw.ActionRow {
});
}
this.add_suffix(gspin);
this.set_css_classes(["spin"]);
this.activatable_widget = gspin;
}
}
Expand Down Expand Up @@ -292,7 +293,7 @@ export class RadioRow extends Adw.ActionRow {

static orientation = Gtk.Orientation.HORIZONTAL;

static spacing = 10;
static spacing = 3;

static valign = Gtk.Align.CENTER;

Expand All @@ -307,6 +308,7 @@ export class RadioRow extends Adw.ActionRow {
const toggle = new Gtk.ToggleButton({ label, ...(group && { group }) });
group ||= toggle;
toggle.active = key === current;
toggle.set_css_classes(["flat"]);
toggle.connect("clicked", () => {
if (toggle.active) {
settings.set_string(bind, labels[toggle.label]);
Expand Down
9 changes: 5 additions & 4 deletions po/es.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ msgid ""
msgstr ""
"Project-Id-Version: Forge\n"
"Report-Msgid-Bugs-To: \n"
"POT-Creation-Date: 2025-05-10 17:37+0100\n"
"POT-Creation-Date: 2025-06-21 23:12+0100\n"
"PO-Revision-Date: 2021-09-18 16:25-0400\n"
"Last-Translator: Jose Maranan <jmmaranan@gmail.com>\n"
"Language-Team: \n"
Expand Down Expand Up @@ -333,7 +333,8 @@ msgid "Logger"
msgstr "Registro"

#: lib/prefs/settings.js:139
msgid "Logger Level"
#, fuzzy
msgid "Log level"
msgstr "Nivel de registro"

#: lib/prefs/widgets.js:43
Expand All @@ -344,12 +345,12 @@ msgstr ""
"<b>PRECAUCIÓN</b>: Activar esta configuración puede provocar errores o hacer "
"que el entorno se bloquee"

#: lib/prefs/widgets.js:219
#: lib/prefs/widgets.js:222
#, fuzzy
msgid "Clear shortcut"
msgstr "Actualizar atajos"

#: lib/prefs/widgets.js:234
#: lib/prefs/widgets.js:239
msgid "Reset to default"
msgstr ""

Expand Down
9 changes: 5 additions & 4 deletions po/fr.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ msgid ""
msgstr ""
"Project-Id-Version: Forge\n"
"Report-Msgid-Bugs-To: \n"
"POT-Creation-Date: 2025-05-10 17:37+0100\n"
"POT-Creation-Date: 2025-06-21 23:12+0100\n"
"PO-Revision-Date: 2023-02-28 17:16-0500\n"
"Last-Translator: Wedone <wedoneofficiel@outlook.fr>\n"
"Language-Team: French - Canada <wroy@proton.me>\n"
Expand Down Expand Up @@ -347,7 +347,8 @@ msgid "Logger"
msgstr "Niveau de journalisation"

#: lib/prefs/settings.js:139
msgid "Logger Level"
#, fuzzy
msgid "Log level"
msgstr "Niveau de journalisation"

#: lib/prefs/widgets.js:43
Expand All @@ -359,12 +360,12 @@ msgstr ""
"ATTENTION : Ces paramètres, lorsqu'ils sont activés, sont bogués ou peuvent "
"causer un plantage de l'environnement de bureau"

#: lib/prefs/widgets.js:219
#: lib/prefs/widgets.js:222
#, fuzzy
msgid "Clear shortcut"
msgstr "Raccourcis pour les conteneurs"

#: lib/prefs/widgets.js:234
#: lib/prefs/widgets.js:239
msgid "Reset to default"
msgstr ""

Expand Down
9 changes: 5 additions & 4 deletions po/it.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ msgid ""
msgstr ""
"Project-Id-Version: Forge\n"
"Report-Msgid-Bugs-To: \n"
"POT-Creation-Date: 2025-05-10 17:37+0100\n"
"POT-Creation-Date: 2025-06-21 23:12+0100\n"
"PO-Revision-Date: 2024-09-15 20:16+0100\n"
"Last-Translator: Albano Battistella <albanobattistella@gmail.com>\n"
"Language-Team: Italian <albanobattistella@gmail.com>\n"
Expand Down Expand Up @@ -342,7 +342,8 @@ msgid "Logger"
msgstr "Log"

#: lib/prefs/settings.js:139
msgid "Logger Level"
#, fuzzy
msgid "Log level"
msgstr "Livello Log"

#: lib/prefs/widgets.js:43
Expand All @@ -353,12 +354,12 @@ msgstr ""
"<b>ATTENZIONE</b>: l'attivazione di questa impostazione può portare a bug o "
"causare il crash della shell"

#: lib/prefs/widgets.js:219
#: lib/prefs/widgets.js:222
#, fuzzy
msgid "Clear shortcut"
msgstr "Scorciatoie per i container"

#: lib/prefs/widgets.js:234
#: lib/prefs/widgets.js:239
msgid "Reset to default"
msgstr ""

Expand Down
9 changes: 5 additions & 4 deletions po/nl.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ msgid ""
msgstr ""
"Project-Id-Version: Forge\n"
"Report-Msgid-Bugs-To: \n"
"POT-Creation-Date: 2025-05-10 17:37+0100\n"
"POT-Creation-Date: 2025-06-21 23:12+0100\n"
"PO-Revision-Date: 2021-12-29 19:04+0100\n"
"Last-Translator: Heimen Stoffels <vistausss@fastmail.com>\n"
"Language-Team: \n"
Expand Down Expand Up @@ -326,7 +326,8 @@ msgid "Logger"
msgstr "Logniveau"

#: lib/prefs/settings.js:139
msgid "Logger Level"
#, fuzzy
msgid "Log level"
msgstr "Logniveau"

#: lib/prefs/widgets.js:43
Expand All @@ -338,12 +339,12 @@ msgstr ""
"<b>LET OP</b>: deze voorkeuren kunnen instabiliteit veroorzaken of zelfs de "
"shell laten crashen!"

#: lib/prefs/widgets.js:219
#: lib/prefs/widgets.js:222
#, fuzzy
msgid "Clear shortcut"
msgstr "Containersneltoetsen"

#: lib/prefs/widgets.js:234
#: lib/prefs/widgets.js:239
msgid "Reset to default"
msgstr ""

Expand Down
9 changes: 5 additions & 4 deletions po/pt_BR.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ msgid ""
msgstr ""
"Project-Id-Version: Forge\n"
"Report-Msgid-Bugs-To: \n"
"POT-Creation-Date: 2025-05-10 17:37+0100\n"
"POT-Creation-Date: 2025-06-21 23:12+0100\n"
"PO-Revision-Date: 2021-09-18 16:25-0400\n"
"Last-Translator: Juarez Rudsatz <juarezr@gmail.com>\n"
"Language-Team: \n"
Expand Down Expand Up @@ -336,7 +336,8 @@ msgid "Logger"
msgstr "Nivel de Log"

#: lib/prefs/settings.js:139
msgid "Logger Level"
#, fuzzy
msgid "Log level"
msgstr "Nivel de Log"

#: lib/prefs/widgets.js:43
Expand All @@ -348,12 +349,12 @@ msgstr ""
"CUIDADO: Estas configurações, quando ativadas, são problemáticas ou podem "
"causar a queda da interface"

#: lib/prefs/widgets.js:219
#: lib/prefs/widgets.js:222
#, fuzzy
msgid "Clear shortcut"
msgstr "Atalhos de Container"

#: lib/prefs/widgets.js:234
#: lib/prefs/widgets.js:239
msgid "Reset to default"
msgstr ""

Expand Down