Skip to content

fix toggle floating regression, closes #492 #496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jmmaranan merged 1 commit into from
Dec 18, 2025
Merged

fix toggle floating regression, closes #492 #496

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions lib/extension/window.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,8 +103,13 @@ export class WindowManager extends GObject.Object {
let wmId = metaWindow.get_id();

for (let override of overrides) {
// if the window is already floating
if (override.wmClass === wmClass && override.mode === "float" && !override.wmTitle) return;
// ignore already floating and find correct window instance
if (override.wmClass === wmClass && override.mode === "float" && !override.wmTitle) {
if (withWmId && override.wmId !== wmId) {
continue;
}
return;
}
}
overrides.push({
wmClass: wmClass,
Expand All @@ -115,6 +120,7 @@ export class WindowManager extends GObject.Object {
// Save the updated overrides back to the ConfigManager
currentProps.overrides = overrides;
this.ext.configMgr.windowProps = currentProps;
this.windowProps = currentProps;
}

removeFloatOverride(metaWindow, withWmId) {
Expand All @@ -135,6 +141,7 @@ export class WindowManager extends GObject.Object {
// Save the updated overrides back to the ConfigManager
currentProps.overrides = overrides;
this.ext.configMgr.windowProps = currentProps;
this.windowProps = currentProps;
}

toggleFloatingMode(action, metaWindow) {
Expand Down