feat(cloudprem): add MANAGED_STACK env var to Portal and Console-V3 #274
Conversation
WalkthroughVersion bumps: Cloudprem 4.0.0-beta.10 → 4.0.0-beta.11; Console-V3 and Portal 3.0.0-beta.5 → 3.0.0-beta.6 (Portal AppVersion v1.17.5 → v1.17.6). Added Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Organization UI Review profile: CHILL Plan: Pro Disabled knowledge base sources:
⛔ Files ignored due to path filters (8)
📒 Files selected for processing (6)
🚧 Files skipped from review as they are similar to previous changes (4)
🧰 Additional context used🪛 LanguageToolREADME.md[style] ~12-~12: Using many exclamation marks might seem excessive (in this case: 9 exclamation marks for a text that’s 2743 characters long) (EN_EXCESSIVE_EXCLAMATION) 🔇 Additional comments (4)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In @charts/console-v3/templates/_helpers.tpl:
- Around line 72-73: Add a new values.yaml containing sensible defaults for the
chart’s referenced config keys so templates referencing
.Values.config.managedStack and .Values.config.environment do not fail;
specifically include config.managedStack: "1" (string) to match the documented
default, add config.environment (e.g., "production" or an empty string) and any
other config.* keys referenced by templates, and ensure the file is committed to
the chart so helm render/deploy has those defaults available.
In @charts/portal/templates/_helpers.tpl:
- Around line 57-58: The chart is missing a local values file so the template
reference to .Values.config.managedStack is undefined; add a
charts/portal/values.yaml file that defines the documented defaults, at minimum
setting config.managedStack: "1", and include any other documented defaults from
README.md so templates like the MANAGED_STACK env value can render standalone;
ensure the file is committed alongside the chart so the template snippet
referencing .Values.config.managedStack | quote resolves correctly.
🧹 Nitpick comments (1)
charts/cloudprem/README.md (1)
563-563: Documentation is clear and consistent.The new
managedStackconfiguration options are well-documented for both console-v3 and portal with clear type, default value, and usage description.📝 Optional: Consider adding more context
The documentation could be enhanced by briefly explaining what "managed stack mode" enables or how it affects the application behavior. This would help users understand when they might want to disable it.
Example:
-| console-v3.config.managedStack | string | `"1"` | Enable managed stack mode (1 = enabled, 0 = disabled) | +| console-v3.config.managedStack | string | `"1"` | Enable managed stack mode to allow stack management operations through the console (1 = enabled, 0 = disabled) |Also applies to: 699-699
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (8)
charts/cloudprem/Chart.lockis excluded by!**/*.lock,!**/*.lockcharts/cloudprem/Chart.yamlis excluded by!**/*.yamlcharts/console-v3/Chart.yamlis excluded by!**/*.yamlcharts/console-v3/values.schema.jsonis excluded by!**/*.jsoncharts/console-v3/values.yamlis excluded by!**/*.yamlcharts/portal/Chart.yamlis excluded by!**/*.yamlcharts/portal/values.schema.jsonis excluded by!**/*.jsoncharts/portal/values.yamlis excluded by!**/*.yaml
📒 Files selected for processing (6)
README.mdcharts/cloudprem/README.mdcharts/console-v3/README.mdcharts/console-v3/templates/_helpers.tplcharts/portal/README.mdcharts/portal/templates/_helpers.tpl
🧰 Additional context used
🪛 LanguageTool
README.md
[style] ~12-~12: Using many exclamation marks might seem excessive (in this case: 9 exclamation marks for a text that’s 2743 characters long)
Context: ...tions, users, roles, and permissions. | 
(EN_EXCESSIVE_EXCLAMATION)
🔇 Additional comments (6)
charts/portal/README.md (2)
3-3: Version badge correctly updated.Portal chart version bumped to 3.0.0-beta.6 with AppVersion v1.17.6 as per PR objectives.
90-90: New config.managedStack parameter properly documented.Clear description of the managed stack mode configuration with explicit enable/disable values. Documentation is consistent with the parameter's purpose. Verified that the MANAGED_STACK environment variable is correctly injected into the Portal deployment template using the config.managedStack value in
charts/portal/templates/_helpers.tplwith proper quoting for YAML safety.charts/console-v3/README.md (2)
3-3: Version badge correctly updated for Console-V3.Chart version bumped to 3.0.0-beta.6 with AppVersion remaining at v1.17.5, consistent with main README.
87-87: Parameter documentation verified and consistent with implementation.MANAGED_STACK environment variable is correctly injected in _helpers.tpl using
{{ .Values.config.managedStack | quote }}, matching the README documentation with identical description ("Enable managed stack mode (1 = enabled, 0 = disabled)") and default value ("1"). Placement is appropriate in the configuration hierarchy.README.md (1)
8-8: Chart versions correctly updated across all files.All version bumps are accurately reflected in both the main README table and Cloudprem chart metadata:
- Cloudprem: 4.0.0-beta.11 ✓
- Console-V3: 3.0.0-beta.6 (AppVersion v1.17.5) ✓
- Portal: 3.0.0-beta.6 (AppVersion v1.17.6) ✓
charts/cloudprem/README.md (1)
4-4: LGTM! Version bump is correct.The version badge update from 4.0.0-beta.10 to 4.0.0-beta.11 aligns with the PR objectives.
| - name: MANAGED_STACK | ||
| value: {{ .Values.config.managedStack | quote }} |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Check if console-v3/values.yaml exists and contains managedStack
fd -t f "values.yaml" charts/console-v3 --exec cat {} \; | grep -A 2 -B 2 "managedStack"Repository: formancehq/helm
Length of output: 41
🏁 Script executed:
#!/bin/bash
# Check if values.yaml exists and show config section
if fd -t f "values.yaml" charts/console-v3; then
echo "=== values.yaml found, showing config section ==="
fd -t f "values.yaml" charts/console-v3 --exec cat {} \; | head -100
echo ""
echo "=== Checking for 'config:' section ==="
fd -t f "values.yaml" charts/console-v3 --exec cat {} \; | grep -A 20 "^config:"
else
echo "values.yaml not found"
fiRepository: formancehq/helm
Length of output: 148
🏁 Script executed:
#!/bin/bash
# List the charts/console-v3 directory structure
echo "=== Directory listing of charts/console-v3 ==="
ls -la charts/console-v3/
echo ""
echo "=== Find all YAML files in charts/console-v3 ==="
fd -t f "\\.yaml$|values" charts/console-v3
echo ""
echo "=== Check for values.yaml with full path and size ==="
find charts/console-v3 -name "values.yaml" -exec ls -lh {} \; -exec wc -l {} \;
echo ""
echo "=== Show full content of values.yaml if it exists ==="
find charts/console-v3 -name "values.yaml" -exec cat {} \;Repository: formancehq/helm
Length of output: 621
🏁 Script executed:
#!/bin/bash
# Check for values.yaml in parent directories and other charts
echo "=== Look for values.yaml in charts directory ==="
find charts -name "values.yaml" -type f
echo ""
echo "=== Check portal chart structure mentioned in review ==="
ls -la charts/portal*/
echo ""
echo "=== Check if there's a values.yaml at repo root ==="
find . -maxdepth 2 -name "values.yaml" -type fRepository: formancehq/helm
Length of output: 574
🏁 Script executed:
#!/bin/bash
# Check the templates directory and the _helpers.tpl file
echo "=== List templates directory ==="
ls -la charts/console-v3/templates/
echo ""
echo "=== Show _helpers.tpl content (lines 70-75) ==="
find charts/console-v3/templates -name "_helpers.tpl" -exec head -80 {} \; | tail -15Repository: formancehq/helm
Length of output: 871
Create charts/console-v3/values.yaml with default configuration values.
The Helm chart references .Values.config.managedStack and .Values.config.environment in the template but no values.yaml file exists in charts/console-v3. This will cause deployment failures. Create a values.yaml file with default values including config.managedStack: "1" to match the documented default and provide sensible defaults for all referenced configuration keys.
🤖 Prompt for AI Agents
In @charts/console-v3/templates/_helpers.tpl around lines 72 - 73, Add a new
values.yaml containing sensible defaults for the chart’s referenced config keys
so templates referencing .Values.config.managedStack and
.Values.config.environment do not fail; specifically include
config.managedStack: "1" (string) to match the documented default, add
config.environment (e.g., "production" or an empty string) and any other
config.* keys referenced by templates, and ensure the file is committed to the
chart so helm render/deploy has those defaults available.
flemzord
force-pushed
the
feat/add-managed-stack-env-var
branch
from
f08da39 to
16fa7c4
Compare
- Add MANAGED_STACK environment variable with default value "1" - Add API_URL env var to Console-V3 (same value as API_STACK_URL) for prod compatibility - Upgrade Portal appVersion to v1.17.6 - Upgrade Console-V3 appVersion to v1.17.6 - Bump chart versions: - portal: 3.0.0-beta.5 -> 3.0.0-beta.6 - console-v3: 3.0.0-beta.5 -> 3.0.0-beta.6 - cloudprem: 4.0.0-beta.10 -> 4.0.0-beta.11
flemzord
force-pushed
the
feat/add-managed-stack-env-var
branch
from
16fa7c4 to
0f9ae51
Compare
Summary
MANAGED_STACKenvironment variable to Portal and Console-V3 deployments"1"(enabled), can be set to"0"to disablev1.17.5tov1.17.6Chart version bumps
Usage
To disable managed stack mode:
Test plan
MANAGED_STACK=1env varMANAGED_STACK=1env var"0"works correctly