Skip to content

Conversation

@JustinWonjaePark
Copy link
Contributor

Description

  • Update Scanner Info Sheet
  • Fix bug related to temp directory

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation update
  • Refactoring, Maintenance
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@JustinWonjaePark JustinWonjaePark self-assigned this Jan 22, 2026
@JustinWonjaePark JustinWonjaePark marked this pull request as ready for review January 22, 2026 10:31
@soimkim soimkim added the chore [PR/Issue] Refactoring, maintenance the code label Jan 22, 2026
@soimkim
Copy link
Contributor

soimkim commented Jan 22, 2026

@JustinWonjaePark ,

run_scanoss_py에서 하기 부분 불필요합니다.

if not called_by_cli:
        global logger
        _start_time = datetime.now().strftime('%y%m%d_%H%M')
        logger, _result_log = init_log(os.path.join(output_path, f"fosslight_log_src_{_start_time}.txt"),
                                       True, logging.INFO, logging.DEBUG, _PKG_NAME, path_to_scan, path_to_exclude)

   if output_path == "":  # if json output with _write_json_file not used, output_path won't be needed.
        output_path = os.getcwd()
    else:
        output_path = os.path.abspath(output_path)
        if not os.path.isdir(output_path):
            Path(output_path).mkdir(parents=True, exist_ok=True)

현재 수정사항대로면 write_json_file 변수도 불필요해보입니다.

Signed-off-by: Wonjae Park <j.wonjae.park@gmail.com>
Signed-off-by: Wonjae Park <j.wonjae.park@gmail.com>
Signed-off-by: Wonjae Park <j.wonjae.park@gmail.com>
Signed-off-by: Wonjae Park <j.wonjae.park@gmail.com>
@JustinWonjaePark JustinWonjaePark marked this pull request as draft January 23, 2026 04:31
Signed-off-by: Wonjae Park <j.wonjae.park@gmail.com>
@JustinWonjaePark JustinWonjaePark marked this pull request as ready for review January 23, 2026 04:59
@JustinWonjaePark JustinWonjaePark merged commit f0203c7 into main Jan 23, 2026
6 checks passed
@JustinWonjaePark JustinWonjaePark deleted the dev_scanner_info branch January 23, 2026 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore [PR/Issue] Refactoring, maintenance the code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants