Skip to content

Conversation

@JustinWonjaePark
Copy link
Contributor

@JustinWonjaePark JustinWonjaePark commented Jan 27, 2026

Description

  • Fix path for intermediate file
  • Fix return type hint for SCANOSS

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation update
  • Refactoring, Maintenance
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Signed-off-by: Wonjae Park <j.wonjae.park@gmail.com>
Signed-off-by: Wonjae Park <j.wonjae.park@gmail.com>
@JustinWonjaePark JustinWonjaePark self-assigned this Jan 27, 2026
@JustinWonjaePark JustinWonjaePark added the bug fix [PR] Fix the bug label Jan 27, 2026
Signed-off-by: Wonjae Park <j.wonjae.park@gmail.com>
@JustinWonjaePark JustinWonjaePark requested review from dd-jy and soimkim and removed request for soimkim January 27, 2026 08:53
Copy link
Contributor

@dd-jy dd-jy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scanoss_output.wfp 파일 삭제 로직도 추가 확인해주시기 바랍니다.

Signed-off-by: Wonjae Park <j.wonjae.park@gmail.com>
@JustinWonjaePark
Copy link
Contributor Author

scanoss_output.wfp 파일 삭제 로직도 추가 확인해주시기 바랍니다.

확인결과 scanoss.py 측에서 스캔 시 wfp 파일을 생성하지 않는 것이 기본으로 변경되었습니다.
이에, -j 옵션 추가 시 wfp 파일을 별도 생성하도록 코드 수정했습니다.

@JustinWonjaePark JustinWonjaePark force-pushed the dev_intermediate_file_bug branch from 7494332 to 3d7cc58 Compare January 28, 2026 06:10
@JustinWonjaePark JustinWonjaePark merged commit 3f61a44 into main Jan 28, 2026
6 checks passed
@JustinWonjaePark JustinWonjaePark deleted the dev_intermediate_file_bug branch January 28, 2026 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug fix [PR] Fix the bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants