You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I only looked at it quickly and I'm not the final authority on this gem, but a few things come to mind:
this mixes independent changes (config vs raw tag). Ideally these would be separate PRs. Also never change version numbers in a PR, that's the job of the maintainers.
For the raw tag, the issue I see is that inky-rb is meant to be the Ruby port of inky, so it should probably support raw tags iff inky does.
For the config part, I believe that ignoring bad values passed (e.g. test "will not set an invalid components override") is not the right way to go. Raise a TypeError instead.
this repo already supports raw tags, but the current implementation in this repo only checks a single line at a time. this is an HTML based library, that's not how users expect HTML parsing to work
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes raw tag parsing mentioned in #95