Skip to content

Remove Windows support #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
franciszekjob merged 3 commits into from
Jun 24, 2025
Merged

Remove Windows support #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c4b042d
Remove running tests on Windows
franciszekjob Jun 23, 2025
34439c6
Fix resolving scarb version
franciszekjob Jun 23, 2025
88ad9b6
Further changes towards Windows support removal
franciszekjob Jun 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 3 additions & 9 deletions .github/workflows/checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,7 @@ jobs:
run: npm run fmt:check

test-action:
runs-on: ${{ matrix.os }}
strategy:
matrix:
os: [ubuntu-latest, windows-latest]
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3

Expand All @@ -38,7 +35,7 @@ jobs:
shell: bash
run: |
snfoundry_version=$(curl -s https://api.github.com/repos/foundry-rs/starknet-foundry/releases/latest | grep tarball_url | awk -F '/' '{print $8}' | tr -d '",')
version=$(curl -s https://raw.githubusercontent.com/foundry-rs/starknet-foundry/$snfoundry_version/.tool-versions | awk '{print $2}')
version=$(curl -s https://raw.githubusercontent.com/foundry-rs/starknet-foundry/$snfoundry_version/.tool-versions | grep '^scarb' | awk '{print $2}')

echo "scarbVersion=$version" >> "$GITHUB_OUTPUT"
- name: Setup Scarb
Expand All @@ -62,10 +59,7 @@ jobs:
working-directory: myproject

test-action-with-tools-file:
runs-on: ${{ matrix.os }}
strategy:
matrix:
os: [ubuntu-latest, windows-latest]
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3

Expand Down
4 changes: 1 addition & 3 deletions dist/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29949,8 +29949,6 @@ function getOsPlatform() {
return "unknown-linux-gnu";
case "darwin":
return "apple-darwin";
case "win32":
return "pc-windows-msvc";
default:
throw new Error(`unsupported host platform: ${platform}`);
}
Expand All @@ -29969,7 +29967,7 @@ async function downloadStarknetFoundry(repo, version) {
const triplet = getOsTriplet();
const tag = versionWithPrefix(version);
const basename = `starknet-foundry-${tag}-${triplet}`;
const extension = triplet.includes("-windows-") ? "zip" : "tar.gz";
const extension = "tar.gz";
const url = `https://github.com/${repo}/releases/download/${tag}/${basename}.${extension}`;

core.info(`Downloading Starknet Foundry from ${url}`);
Expand Down
2 changes: 1 addition & 1 deletion lib/download.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ export async function downloadStarknetFoundry(repo, version) {
const triplet = getOsTriplet();
const tag = versionWithPrefix(version);
const basename = `starknet-foundry-${tag}-${triplet}`;
const extension = triplet.includes("-windows-") ? "zip" : "tar.gz";
const extension = "tar.gz";
const url = `https://github.com/${repo}/releases/download/${tag}/${basename}.${extension}`;

core.info(`Downloading Starknet Foundry from ${url}`);
Expand Down
2 changes: 0 additions & 2 deletions lib/platform.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,6 @@ export function getOsPlatform() {
return "unknown-linux-gnu";
case "darwin":
return "apple-darwin";
case "win32":
return "pc-windows-msvc";
default:
throw new Error(`unsupported host platform: ${platform}`);
}
Expand Down
Loading