Support creation of troop segment actors#21564
Support creation of troop segment actors#21564CarlosFdez wants to merge 1 commit intofoundryvtt:v13-devfrom
Conversation
CarlosFdez
force-pushed
the
troop-segments
branch
from
ba88f44 to
fea7d13
Compare
CarlosFdez
changed the title
CarlosFdez
force-pushed
the
troop-segments
branch
2 times, most recently
from
6da7886 to
4da0958
Compare
src/module/actor/npc/document.ts
Outdated
There was a problem hiding this comment.
Is this not already constructed for NPCs?
There was a problem hiding this comment.
No, only in the base actor. It is standard practice to replace it though, familiars and characters both do that.
In this case we need an actor size that continues to report gargantuan but creates a 2x2 actor.
There was a problem hiding this comment.
you can adjust the wide/long values after it's constructed
There was a problem hiding this comment.
Would it be reasonable to request height here? So that a segment is not a cube for measuring vertical distance.
There was a problem hiding this comment.
Of an actor/segment. Troop is made of individual creatures, which are not necessary Gangantuan/Large size each.
Current distance calculation considers tokens to be cubes stretching from the ground up, which results in distance calculation that is suitable for individual creatures, but doesn't necessary make sense for large groups of smaller creatures (#20169).
There was a problem hiding this comment.
I'm poking into it and while I agree, that doesn't seem to be part of the actor size object.
The overwrites worked. Dunno why I though they'd be read only. Must have skimmed.
There was a problem hiding this comment.
It looks like the height is the lesser of long/wide, and is part of the actor dimensions property. Its already handled.
CarlosFdez
force-pushed
the
troop-segments
branch
2 times, most recently
from
bc6e5c7 to
3e78a6d
Compare
CarlosFdez
force-pushed
the
troop-segments
branch
from
3e78a6d to
5e4626e
Compare
3 participants
There is no handling for HP syncing yet, nor death handling. I want to be sure this looks ok before continuing on.