Skip to content

Conversation

@Nick-Lucas
Copy link
Contributor

@Nick-Lucas Nick-Lucas commented Jan 12, 2026

Description

Adds support for the new displayTime flag on date fields, adds inference for times in JS/ISO format.

Rather than trying to support arbitrary flags across the system, we now map the field.type to a "virtual" type which splits date fields by displayTime into a datetime type. This simplifies things a lot

image image

Testing

people.csv

  • Upload people.csv on a new collection and ensure the date and datetime fields are detected correctly
  • Upload people.csv on a existing collection and ensure the data maps and imports correctly

@Nick-Lucas Nick-Lucas requested a review from Copilot January 12, 2026 14:48
@Nick-Lucas Nick-Lucas requested a review from triozer January 12, 2026 14:51
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds support for distinguishing between date-only and datetime (date+time) fields during CSV import, leveraging a new displayTime flag available on date fields in the updated framer-plugin SDK.

Changes:

  • Introduces a virtual type system that treats "datetime" as a distinct type from "date" for UI purposes while mapping both to the SDK's date type with different displayTime values
  • Updates type inference to detect time components in date strings and infer "datetime" vs "date" accordingly
  • Adds compatibility logic to allow date and datetime fields to be mapped to each other during import

Reviewed changes

Copilot reviewed 8 out of 11 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
yarn.lock Updates framer-plugin dependency from 3.10.0-alpha.1 to 3.10.0-alpha.2
package.json Updates framer-plugin dependency to 3.10.0-alpha.2
virtualTypes.ts New file defining VirtualFieldType and conversion logic from SDK types to virtual types
typeInference.ts Adds hasTimeComponent function and updates inference to distinguish date from datetime
typeCompatibility.ts Adds compatibility between date and datetime types for field mapping
fieldReconciliation.ts Updates field creation to set displayTime property based on virtual type
fieldLabels.ts Adds "DateTime" label for the datetime virtual type
FieldMapper.tsx Updates to use virtual types for type compatibility checking
FieldMapperRow.tsx Updates to display virtual types correctly in the UI
.yarn/cache/* Updated yarn cache for new framer-plugin version

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Member

@triozer triozer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pre-approving, left one comment!

@Nick-Lucas Nick-Lucas added this pull request to the merge queue Jan 12, 2026
Merged via the queue into main with commit 8af5892 Jan 12, 2026
10 checks passed
@Nick-Lucas Nick-Lucas deleted the feature/35653-cash-import-datetime branch January 12, 2026 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants