Skip to content

Conversation

@DanielRosa74
Copy link
Contributor

Checklist:

@DanielRosa74 DanielRosa74 requested a review from a team as a code owner December 19, 2025 13:02
@DanielRosa74 DanielRosa74 enabled auto-merge (squash) December 19, 2025 13:03
Copy link
Member

@huyenltnguyen huyenltnguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diff shows this is a new addition, but looks like we already have this file: https://github.com/freeCodeCamp/cdn/blob/main/build/curriculum/english/animation-assets/sounds/ZH_A1_pinyin_initials.mp3

Could you confirm if this change is a replacement or an addition?

@huyenltnguyen huyenltnguyen changed the title fix_missing_initial fix: zh a1 pinyin initials audio Dec 19, 2025
@DanielRosa74
Copy link
Contributor Author

The diff shows this is a new addition, but looks like we already have this file: https://github.com/freeCodeCamp/cdn/blob/main/build/curriculum/english/animation-assets/sounds/ZH_A1_pinyin_initials.mp3

Could you confirm if this change is a replacement or an addition?

It's meant to be a replacement. It overwrote my file on local.

@huyenltnguyen huyenltnguyen changed the title fix: zh a1 pinyin initials audio fix: replace zh a1 pinyin initials audio Dec 19, 2025
@huyenltnguyen huyenltnguyen merged commit d009f84 into freeCodeCamp:main Dec 19, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants